<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer][MSE] Crash on youtube when MSE is enabled but gstreamer cant find the decoder element."
href="https://bugs.webkit.org/show_bug.cgi?id=167120#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer][MSE] Crash on youtube when MSE is enabled but gstreamer cant find the decoder element."
href="https://bugs.webkit.org/show_bug.cgi?id=167120">bug 167120</a>
from <span class="vcard"><a class="email" href="mailto:eocanha@igalia.com" title="Enrique Ocaña <eocanha@igalia.com>"> <span class="fn">Enrique Ocaña</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=304937&action=diff" name="attach_304937" title="Patch">attachment 304937</a> <a href="attachment.cgi?id=304937&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=304937&action=review">https://bugs.webkit.org/attachment.cgi?id=304937&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:113
> +bool doInitializeGStreamerAndRegisterWebKitElements()</span >
I'd thank feedback from some reviewer about if this is the best way to expose the original initializeGStreamerAndRegisterWebKitElements() internal function to be called from another internal function in MediaPlayerPrivateGStreamer.cpp.
If resorting to declare a friend function is too cumbersome, maybe a more direct approach would be to just declare the original initializeGStreamerAndRegisterWebKitElements() publicly in the header file. I'm still not sure.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:776
> + Vector<GstCapsWebKitMapping> mapping = {</span >
It's great that you have removed the old elements not mapping to any webkitCodecs.
Now the AudioDecoder elementType category has no elements. Still, I think keeping this AudioDecoder/VideoDecoder distinction is useful in case we add support for more mime types in MSE in the future.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:837
> + for (String pattern : codecSet()) {</span >
If you use "const auto&" here instead of String, you're avoiding String copies and increasing the performance.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>