<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a warning for unused link preloads."
href="https://bugs.webkit.org/show_bug.cgi?id=165670#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a warning for unused link preloads."
href="https://bugs.webkit.org/show_bug.cgi?id=165670">bug 165670</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=304495&action=diff" name="attach_304495" title="Patch">attachment 304495</a> <a href="attachment.cgi?id=304495&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=304495&action=review">https://bugs.webkit.org/attachment.cgi?id=304495&action=review</a>
<span class="quote">> Source/WebCore/loader/cache/CachedResourceClient.h:48
> + virtual bool markAsReferenced() const { return true; }</span >
I'm not sure this is named correctly. shouldMarkAsReferenced? Isn't there already a way to tell if a load is a preload?
<span class="quote">> LayoutTests/TestExpectations:1260
> +http/tests/preload/single_download_preload.html [ DumpJSConsoleLogInStdErr ]</span >
Does this make these tests not accidentally print out a warning message? Is there no way to do this from within the test?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>