<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESnext] Implement Object Spread"
href="https://bugs.webkit.org/show_bug.cgi?id=167963">bug 167963</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #304453 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESnext] Implement Object Spread"
href="https://bugs.webkit.org/show_bug.cgi?id=167963#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESnext] Implement Object Spread"
href="https://bugs.webkit.org/show_bug.cgi?id=167963">bug 167963</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=304453&action=diff" name="attach_304453" title="Proposed Patch for Landing">attachment 304453</a> <a href="attachment.cgi?id=304453&action=edit" title="Proposed Patch for Landing">[details]</a></span>
Proposed Patch for Landing
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=304453&action=review">https://bugs.webkit.org/attachment.cgi?id=304453&action=review</a>
r=me with comments.
<span class="quote">> Source/JavaScriptCore/builtins/GlobalOperations.js:89
> + if (source === @undefined || source == null)</span >
`source == null` includes `source === @undefined`. So drop `source === @undefined` part.
<span class="quote">> Source/JavaScriptCore/bytecode/CodeBlock.cpp:878
> + const HashSet<RefPtr<UniquedStringImpl>>& set = entry.first;</span >
If HashSet does not include any nullptr, we should use Ref<>.
In this case, I think we shoud use Ref<> instead of RefPtr<>.
<span class="quote">> Source/JavaScriptCore/bytecode/CodeBlock.cpp:879
> for (auto setEntry : set) {</span >
It becomes `auto& `
<span class="quote">> Source/JavaScriptCore/bytecode/CodeBlock.cpp:880
> + JSString* jsString = jsOwnedString(&vm, setEntry.get());</span >
And it becomes `setEntry.ptr().
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1925
> for (ConstantIndentifierSetEntry entry : m_codeBlock->constantIdentifierSets()) {</span >
This always copies HashSet. Let's use `const auto& entry` instead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>