<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESnext] Implement Object Spread"
href="https://bugs.webkit.org/show_bug.cgi?id=167963">bug 167963</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #304214 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESnext] Implement Object Spread"
href="https://bugs.webkit.org/show_bug.cgi?id=167963#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESnext] Implement Object Spread"
href="https://bugs.webkit.org/show_bug.cgi?id=167963">bug 167963</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=304214&action=diff" name="attach_304214" title="Patch">attachment 304214</a> <a href="attachment.cgi?id=304214&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=304214&action=review">https://bugs.webkit.org/attachment.cgi?id=304214&action=review</a>
r=me with comments.
<span class="quote">> Source/JavaScriptCore/builtins/BuiltinNames.h:73
> + macro(getOwnPropertySymbols) \</span >
I think it is not necessary. The reason will be described in the following comments :).
<span class="quote">> Source/JavaScriptCore/builtins/GlobalOperations.js:90
> return target;</span >
How about just using `== null`?
<span class="quote">> Source/JavaScriptCore/builtins/GlobalOperations.js:92
> let from = @toObject(source);</span >
I think we should use `@Object(source)` here. And we can drop `@toObject`.
`@Object` is nice because it is well handled in DFG :) (Like, if source is likely an object, we emit the fixup edge and drop @Object call!).
<span class="quote">> Source/JavaScriptCore/builtins/GlobalOperations.js:94
> + let propertyNames = @Object.@getOwnPropertyNames(from);
> + let keys = propertyNames.@concat(@Object.@getOwnPropertySymbols(from));</span >
You can use @Reflect.@ownKeys().
<span class="quote">> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:4238
> + HashSet<UniquedStringImpl*> excludedSet;</span >
BTW, who guarantees this UniquedStringImpl*'s lifetime? Is HashSet<Ref<UniquedStringImpl>> correct?
<span class="quote">> Source/JavaScriptCore/parser/NodeConstructors.h:239
> + : m_name(0)</span >
Use nullptr.
<span class="quote">> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:93
> + JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->builtinNames().concatPrivateName(), arrayPrototypeConcatCodeGenerator, DontEnum | DontDelete | ReadOnly);</span >
So I think it is not necessary.
<span class="quote">> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:108
> + JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->builtinNames().getOwnPropertySymbolsPrivateName(), objectConstructorGetOwnPropertySymbols, DontEnum, 1);</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>