<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add function webkit_dom_element_get_bounding_client_rect"
href="https://bugs.webkit.org/show_bug.cgi?id=163892">bug 163892</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #303650 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add function webkit_dom_element_get_bounding_client_rect"
href="https://bugs.webkit.org/show_bug.cgi?id=163892#c30">Comment # 30</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add function webkit_dom_element_get_bounding_client_rect"
href="https://bugs.webkit.org/show_bug.cgi?id=163892">bug 163892</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303650&action=diff" name="attach_303650" title="Patch">attachment 303650</a> <a href="attachment.cgi?id=303650&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303650&action=review">https://bugs.webkit.org/attachment.cgi?id=303650&action=review</a>
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp:26
> +static bool testClientRectPosition(WebKitDOMClientRect* clientRect)</span >
This is only used inside the WebKitDOMClientRectTest, it can be a static function in the class instead of here. If you don't want it to look like a test case just renamed to something like checkClientRectPosition.
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp:49
> + gfloat top, right, bottom, left, width, height;
> + g_object_get(clientRect,
> + "top", &top,
> + "right", &right,
> + "bottom", &bottom,
> + "left", &left,
> + "width", &width,
> + "height", &height, nullptr);
> + g_assert_cmpfloat(top, ==, -25);
> + g_assert_cmpfloat(right, ==, 50);
> + g_assert_cmpfloat(bottom, ==, 175);
> + g_assert_cmpfloat(left, ==, -50);
> + g_assert_cmpfloat(width, ==, 100);
> + g_assert_cmpfloat(height, ==, 200);</span >
We don't need to test this twice, g_object_get uses the public getters in the end
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp:51
> + return true;</span >
Test cases are boolean because they might return false to indicate that the test failed, even though most of the times they just r4eturn true and use asserts to make something fail.. But this is just a helper function.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>