<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebGPU prototype"
href="https://bugs.webkit.org/show_bug.cgi?id=167952#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebGPU prototype"
href="https://bugs.webkit.org/show_bug.cgi?id=167952">bug 167952</a>
from <span class="vcard"><a class="email" href="mailto:commit-queue@webkit.org" title="WebKit Commit Bot <commit-queue@webkit.org>"> <span class="fn">WebKit Commit Bot</span></a>
</span></b>
<pre><span class=""><a href="attachment.cgi?id=304103&action=diff" name="attach_304103" title="Frontend patch that should build when WEBGPU not defined">Attachment 304103</a> <a href="attachment.cgi?id=304103&action=edit" title="Frontend patch that should build when WEBGPU not defined">[details]</a></span> did not pass style-queue:
ERROR: Source/WebCore/html/canvas/WebGPURenderingContext.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderingContext.cpp:43: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderingContext.cpp:90: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderingContext.cpp:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.h:51: The parameter name "buffer" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.h:51: Omit int when using unsigned [runtime/unsigned] [1]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.h:52: The parameter name "buffer" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.h:52: Omit int when using unsigned [runtime/unsigned] [1]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.h:53: Omit int when using unsigned [runtime/unsigned] [1]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/mac/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit2/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5]
ERROR: Source/WebCore/html/canvas/WebGPUCommandBuffer.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPUTextureDescriptor.cpp:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/html/canvas/WebGPURenderPipelineState.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderPassDescriptor.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderPassDescriptor.cpp:34: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderPassDescriptor.cpp:46: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderPassDescriptor.cpp:76: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/html/canvas/WebGPUCommandBuffer.h:51: The parameter name "descriptor" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGPUObject.h:48: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGPURenderPipelineDescriptor.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderPipelineDescriptor.cpp:35: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderPipelineDescriptor.cpp:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/html/canvas/WebGPURenderPipelineDescriptor.cpp:112: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/html/canvas/WebGPUDepthStencilDescriptor.cpp:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.cpp:74: Omit int when using unsigned [runtime/unsigned] [1]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.cpp:82: Omit int when using unsigned [runtime/unsigned] [1]
ERROR: Source/WebCore/html/canvas/WebGPURenderCommandEncoder.cpp:90: Omit int when using unsigned [runtime/unsigned] [1]
ERROR: Source/WebCore/html/canvas/WebGPUDepthStencilState.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 35 in 72 files
If any of these errors are false positives, please file a bug against check-webkit-style.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>