<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - MiniBrowser: a tab closed from javascript always closes the window"
href="https://bugs.webkit.org/show_bug.cgi?id=169415">bug 169415</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #303922 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MiniBrowser: a tab closed from javascript always closes the window"
href="https://bugs.webkit.org/show_bug.cgi?id=169415#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MiniBrowser: a tab closed from javascript always closes the window"
href="https://bugs.webkit.org/show_bug.cgi?id=169415">bug 169415</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303922&action=diff" name="attach_303922" title="Patch">attachment 303922</a> <a href="attachment.cgi?id=303922&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303922&action=review">https://bugs.webkit.org/attachment.cgi?id=303922&action=review</a>
<span class="quote">> Tools/MiniBrowser/gtk/BrowserWindow.c:268
> + for (int i = 0; i < tabsCount; ++i) {</span >
It fails with GCC 4.9:
../../Tools/MiniBrowser/gtk/BrowserWindow.c: In function 'webViewClose':
../../Tools/MiniBrowser/gtk/BrowserWindow.c:268:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
../../Tools/MiniBrowser/gtk/BrowserWindow.c:268:5: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
Maybe we should specify --std=c11 for compiling MiniBrowser, since that's clearly what we are all using.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>