<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for Bindings EWS"
href="https://bugs.webkit.org/show_bug.cgi?id=169308#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for Bindings EWS"
href="https://bugs.webkit.org/show_bug.cgi?id=169308">bug 169308</a>
from <span class="vcard"><a class="email" href="mailto:aakash_jain@apple.com" title="Aakash Jain <aakash_jain@apple.com>"> <span class="fn">Aakash Jain</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303745&action=diff" name="attach_303745" title="Patch">attachment 303745</a> <a href="attachment.cgi?id=303745&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303745&action=review">https://bugs.webkit.org/attachment.cgi?id=303745&action=review</a>
overall looks good to me. Few comments inline.
<span class="quote">> Tools/Scripts/webkitpy/tool/bot/jscews_unittest.py:223
> +class MockBindingsEarlyWarningSystem(AbstractEarlyWarningSystem):</span >
The filename is jscews_unittest.py, should either rename the file or move the binding test code to a new file.
<span class="quote">> Tools/Scripts/webkitpy/tool/bot/jscews_unittest.py:260
> + with self.assertRaises(ScriptError):</span >
why do we need this? If it is required, shouldn't it be required in all the similar failure test cases below (e.g.: test_ineffective_patch)?
<span class="quote">> Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:194
> + if hasattr(self._delegate, 'group') and self._delegate.should_build:</span >
do we need to check for 'group' here.
Also does all the delegates have should_build? I think it should be fine, but please verify for CommitQueueTaskDelegate and StyleQueueTaskDelegate.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>