<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:koivisto@iki.fi" title="Antti Koivisto <koivisto@iki.fi>"> <span class="fn">Antti Koivisto</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkProcess aborts in WebKit::NetworkLoad::didCompleteWithError at Source/WebKit2/NetworkProcess/NetworkLoad.cpp:423"
href="https://bugs.webkit.org/show_bug.cgi?id=168963">bug 168963</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #302929 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkProcess aborts in WebKit::NetworkLoad::didCompleteWithError at Source/WebKit2/NetworkProcess/NetworkLoad.cpp:423"
href="https://bugs.webkit.org/show_bug.cgi?id=168963#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkProcess aborts in WebKit::NetworkLoad::didCompleteWithError at Source/WebKit2/NetworkProcess/NetworkLoad.cpp:423"
href="https://bugs.webkit.org/show_bug.cgi?id=168963">bug 168963</a>
from <span class="vcard"><a class="email" href="mailto:koivisto@iki.fi" title="Antti Koivisto <koivisto@iki.fi>"> <span class="fn">Antti Koivisto</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=302929&action=diff" name="attach_302929" title="Patch">attachment 302929</a> <a href="attachment.cgi?id=302929&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302929&action=review">https://bugs.webkit.org/attachment.cgi?id=302929&action=review</a>
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:86
> - didComplete();
> -
> - // This causes call to didFailLoading().
> - if (load)
> + if (load) {
> + // This causes call to didFailLoading() that calls didComplete().
> load->continueWillSendRequest({ });
> + } else
> + didComplete();</span >
This would break the functionality since didFailLoading will null out the m_response before didComplete. I think the right fix is just to remove the continueWillSendRequest and let the load be deleted.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>