<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WkWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WkWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225">bug 165225</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=302902&action=diff" name="attach_302902" title="Patch">attachment 302902</a> <a href="attachment.cgi?id=302902&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302902&action=review">https://bugs.webkit.org/attachment.cgi?id=302902&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:583
> + _presentationViewController = nil;</span >
I don't think there's any purpose in keeping the _presentationViewController ivar if it's going to be nil in all circumstances outside of this method. Is this approach any different than just removing
if (_presentationViewController) {
[_presentationViewController dismissViewControllerAnimated:animated completion:^{
_presentationViewController = nil;
}];
}
in -_dismissDisplayAnimated:?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>