<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] Hangs when showing Google search results"
href="https://bugs.webkit.org/show_bug.cgi?id=168699#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] Hangs when showing Google search results"
href="https://bugs.webkit.org/show_bug.cgi?id=168699">bug 168699</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=168699#c15">comment #15</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=302650&action=diff" name="attach_302650" title="Updated patch">attachment 302650</a> <a href="attachment.cgi?id=302650&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=302650&action=review">https://bugs.webkit.org/attachment.cgi?id=302650&action=review</a>
>
> > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:477
> > +#if PLATFORM(GTK)
>
> Why is there anything GTK-specific in ConnectionUnix.cpp? Can't we align our
> code with the other ports to avoid GTK-specific bugs?</span >
There's nothing GTK+ specific, it's glib, but EFL didn't use our gsocket monitor, I don't know why, so we had to use PLATFORM(GTK) instead of USE(GLIB). I agree we could have used USE(GLIB) && !PLATFORM(EFL), though. This bug is not GTK specific at all, the problem was in the poll we used when sendmsg returns EWOULDBLOCK. The solution is GTK+ specific, well, GLib specific, because we use our socket monitor to properly poll the socket also for writing in case of EWOULBLOCK using the run loop.
<span class="quote">> At the very very least, all of these should be changed to if USE(GLIB),
> right?</span >
Right, now that EFL is gone, that's exactly my plan. We could also make it ifdef free by converting our socket monitor into a platform-specific class with platform implementations. However, now that there's no other unix ports using this code, it's not easy for me to do that refactoring without knowing the other implementations.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>