<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add ability for webkitpy to run bindings tests"
href="https://bugs.webkit.org/show_bug.cgi?id=168979#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add ability for webkitpy to run bindings tests"
href="https://bugs.webkit.org/show_bug.cgi?id=168979">bug 168979</a>
from <span class="vcard"><a class="email" href="mailto:svijayaraghavan@apple.com" title="Sri Vijayaraghavan <svijayaraghavan@apple.com>"> <span class="fn">Sri Vijayaraghavan</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=168979#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=302955&action=diff" name="attach_302955" title="Patch">attachment 302955</a> <a href="attachment.cgi?id=302955&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=302955&action=review">https://bugs.webkit.org/attachment.cgi?id=302955&action=review</a>
>
> looks good to me.
>
> > Tools/Scripts/webkitpy/tool/steps/runtests.py:168
> > + self._tool.filesystem.maybe_make_directory(results_directory)
>
> do we need similar line in _run_javascriptcore_tests as well above.</span >
JSC tests cannot run without building, so if the WebKitBuild/[Release/Debug] directory doesn't exist at the time of writing the test results to a file, something would have gone very wrong.
Adding the line enables some code to be abstracted out, but I'd prefer to not abstract things out until we have another group of tests.
Some things, like the results directory, might change by then. Placing results inside WebKitBuild/ for consistency is OK, but it might make sense to move as we add more tests that don't require a build to run (bindings is one of them, also webkitpy, webkitperl etc).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>