<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:achristensen&#64;apple.com" title="Alex Christensen &lt;achristensen&#64;apple.com&gt;"> <span class="fn">Alex Christensen</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo][MiniBrowser] Add ca-bundle to display secure pages"
   href="https://bugs.webkit.org/show_bug.cgi?id=168486">bug 168486</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #302689 Flags</td>
           <td>review?
           </td>
           <td>review-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo][MiniBrowser] Add ca-bundle to display secure pages"
   href="https://bugs.webkit.org/show_bug.cgi?id=168486#c6">Comment # 6</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo][MiniBrowser] Add ca-bundle to display secure pages"
   href="https://bugs.webkit.org/show_bug.cgi?id=168486">bug 168486</a>
              from <span class="vcard"><a class="email" href="mailto:achristensen&#64;apple.com" title="Alex Christensen &lt;achristensen&#64;apple.com&gt;"> <span class="fn">Alex Christensen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=302689&amp;action=diff" name="attach_302689" title="Patch">attachment 302689</a> <a href="attachment.cgi?id=302689&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302689&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=302689&amp;action=review</a>

<span class="quote">&gt; Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:102
&gt; +    char* envPath = getenv(&quot;CURL_CA_BUNDLE_PATH&quot;);</span >

Preferring this if it exists seems ok.

<span class="quote">&gt; Tools/MiniBrowser/win/CMakeLists.txt:41
&gt; +    file(DOWNLOAD ${MiniBrowser_CABUNDLE_URL} &quot;${MiniBrowser_CERTIFICATES_DIR}/cacert.pem&quot; SHOW_PROGRESS)</span >

I'm not sure it's a good idea to download this file every time you build.  It could slow things down, it would require network access while building or fail, it would ping the curl server every time a developer runs cmake and developers might worry that they are being tracked, and CMake's file(DOWNLOAD ...) seems to ignore ssl errors, so it's unclear how secure it really is.  It would be nice to print out instructions for how to get the cacert.pem, but I don't think this is a good idea to commit to the repository as-is.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>