<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Downloads attributes tests are failing"
   href="https://bugs.webkit.org/show_bug.cgi?id=168871#c6">Comment # 6</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Downloads attributes tests are failing"
   href="https://bugs.webkit.org/show_bug.cgi?id=168871">bug 168871</a>
              from <span class="vcard"><a class="email" href="mailto:cgarcia&#64;igalia.com" title="Carlos Garcia Campos &lt;cgarcia&#64;igalia.com&gt;"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
        <pre>(In reply to <a href="show_bug.cgi?id=168871#c4">comment #4</a>)
<span class="quote">&gt; Comment on <span class=""><a href="attachment.cgi?id=302784&amp;action=diff" name="attach_302784" title="Patch">attachment 302784</a> <a href="attachment.cgi?id=302784&amp;action=edit" title="Patch">[details]</a></span>
&gt; Patch
&gt; 
&gt; View in context:
&gt; <a href="https://bugs.webkit.org/attachment.cgi?id=302784&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=302784&amp;action=review</a>
&gt; 
&gt; &gt; LayoutTests/ChangeLog:10
&gt; &gt; +        differently but download success.
&gt; 
&gt; success -&gt; succeeds</span >

Oops.

<span class="quote">&gt; &gt; Source/WebCore/ChangeLog:9
&gt; &gt; +        Use libsoup to get the suggested filename from the Content-Disposition header instead of buggy
&gt; &gt; +        filenameFromHTTPContentDisposition().
&gt; 
&gt; What is buggy about it? Shouldn't we fix that bug, especially if it's
&gt; affecting all ports? It sounds like it requires a adding FIXME at least?</span >

It's buggy because there's already a FIXME comment explaining it:

// FIXME: This function doesn't comply with RFC 6266.                                                                                                                                         
// For example, this function doesn't handle the interaction between &quot; and ;                                                                                                                  
// that arises from quoted-string, nor does this function properly unquote                                                                                                                    
// attribute values. Further this function appears to process parameter names                                                                                                                 
// in a case-sensitive manner. (There are likely other bugs as well.)                                                                                                                         
String filenameFromHTTPContentDisposition(const String&amp; value)

It doesn't affect other ports, it's only used by curl backend, I think. I don't even know what other port is using curl, I guess it's WinCairo.

<span class="quote">&gt; I'd rather use libsoup to get the filename *inside* the implementation of
&gt; filenameFromHTTPContentDisposition if need be. Avoiding use of
&gt; filenameFromHTTPContentDisposition feels like a workaround.</span >

I don't think so, I see filenameFromHTTPContentDisposition as a platform independent fallback implementation when your platform code doesn't provide a better way.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>