<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ryanhaddad@apple.com" title="Ryan Haddad <ryanhaddad@apple.com>"> <span class="fn">Ryan Haddad</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - op_get_by_id_with_this should use inline caching"
href="https://bugs.webkit.org/show_bug.cgi?id=162124">bug 162124</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>ryanhaddad@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - op_get_by_id_with_this should use inline caching"
href="https://bugs.webkit.org/show_bug.cgi?id=162124#c88">Comment # 88</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - op_get_by_id_with_this should use inline caching"
href="https://bugs.webkit.org/show_bug.cgi?id=162124">bug 162124</a>
from <span class="vcard"><a class="email" href="mailto:ryanhaddad@apple.com" title="Ryan Haddad <ryanhaddad@apple.com>"> <span class="fn">Ryan Haddad</span></a>
</span></b>
<pre>The JSC test for this change is timing out on debug:
<a href="https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20%28Tests%29/builds/437">https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20%28Tests%29/builds/437</a>
There also appear to be 73 tests asserting during 32-bit JSC testing:
stress/super-get-by-id.js.default: ASSERTION FAILED: !info.alive()
stress/super-get-by-id.js.default: /Volumes/Data/slave/sierra-32bitJSC-debug/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp(1773) : void JSC::DFG::SpeculativeJIT::compileCurrentBlock()
stress/super-get-by-id.js.default: 1 0x11f283a WTFCrash
stress/super-get-by-id.js.default: 2 0x902c27 JSC::DFG::SpeculativeJIT::compileCurrentBlock()
stress/super-get-by-id.js.default: 3 0x90383f JSC::DFG::SpeculativeJIT::compile()
stress/super-get-by-id.js.default: 4 0x79828c JSC::DFG::JITCompiler::compileBody()
stress/super-get-by-id.js.default: 5 0x79d70a JSC::DFG::JITCompiler::compileFunction()
stress/super-get-by-id.js.default: 6 0x8a6593 JSC::DFG::Plan::compileInThreadImpl(JSC::DFG::LongLivedState&)
stress/super-get-by-id.js.default: 7 0x8a3593 JSC::DFG::Plan::compileInThread(JSC::DFG::LongLivedState&, JSC::DFG::ThreadData*)
stress/super-get-by-id.js.default: 8 0x70ca99 JSC::DFG::compileImpl(JSC::VM&, JSC::CodeBlock*, JSC::CodeBlock*, JSC::DFG::CompilationMode, unsigned int, JSC::Operands<JSC::JSValue> const&, WTF::Ref<JSC::DeferredCompilationCallback>&&)
stress/super-get-by-id.js.default: 9 0x70c499 JSC::DFG::compile(JSC::VM&, JSC::CodeBlock*, JSC::CodeBlock*, JSC::DFG::CompilationMode, unsigned int, JSC::Operands<JSC::JSValue> const&, WTF::Ref<JSC::DeferredCompilationCallback>&&)
stress/super-get-by-id.js.default: 10 0xc4ce06 operationOptimize
stress/super-get-by-id.js.default: 11 0x334cc1c
stress/super-get-by-id.js.default: 12 0xe3fd2c vmEntryToJavaScript
stress/super-get-by-id.js.default: 13 0xc2c378 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
stress/super-get-by-id.js.default: 14 0xbd51cf JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)
stress/super-get-by-id.js.default: 15 0x414857 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)
stress/super-get-by-id.js.default: 16 0xa9ede8 JSC::callGetter(JSC::ExecState*, JSC::JSValue, JSC::JSValue)
stress/super-get-by-id.js.default: 17 0x103671d JSC::PropertySlot::functionGetter(JSC::ExecState*) const
stress/super-get-by-id.js.default: 18 0x2ebf0e JSC::PropertySlot::getValue(JSC::ExecState*, JSC::PropertyName) const
stress/super-get-by-id.js.default: 19 0x2ebcc4 JSC::JSValue::get(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) const
stress/super-get-by-id.js.default: 20 0xc43968 operationGetById
stress/super-get-by-id.js.default: 21 0x3214f77
stress/super-get-by-id.js.default: 22 0x320b48c
stress/super-get-by-id.js.default: 23 0xe3fd2c vmEntryToJavaScript
stress/super-get-by-id.js.default: 24 0xc2c378 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
stress/super-get-by-id.js.default: 25 0xbd440d JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*)
stress/super-get-by-id.js.default: 26 0x4ef1a5 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
stress/super-get-by-id.js.default: 27 0x9bb31 runWithScripts(GlobalObject*, WTF::Vector<Script, 0ul, WTF::CrashOnOverflow, 16ul> const&, WTF::String const&, bool, bool, bool)
stress/super-get-by-id.js.default: 28 0x592a7 jscmain(int, char**)::$_7::operator()(JSC::VM&, GlobalObject*) const
stress/super-get-by-id.js.default: 29 0x499b0 int runJSC<jscmain(int, char**)::$_7>(CommandLine, jscmain(int, char**)::$_7 const&)
stress/super-get-by-id.js.default: 30 0x4837b jscmain(int, char**)
stress/super-get-by-id.js.default: 31 0x482e7 main
stress/super-get-by-id.js.default: test_script_7560: line 2: 43316 Segmentation fault: 11 ( "$@" ../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --maxPerThreadStackUsage\=1572864 --useFTLJIT\=true super-get-by-id.js )
stress/super-get-by-id.js.default: ERROR: Unexpected exit code: 139
<a href="https://build.webkit.org/builders/Apple%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/720">https://build.webkit.org/builders/Apple%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/720</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>