<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Downloads attributes tests are failing"
href="https://bugs.webkit.org/show_bug.cgi?id=168871">bug 168871</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #302784 Flags</td>
<td>commit-queue-
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Downloads attributes tests are failing"
href="https://bugs.webkit.org/show_bug.cgi?id=168871#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Downloads attributes tests are failing"
href="https://bugs.webkit.org/show_bug.cgi?id=168871">bug 168871</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=302784&action=diff" name="attach_302784" title="Patch">attachment 302784</a> <a href="attachment.cgi?id=302784&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302784&action=review">https://bugs.webkit.org/attachment.cgi?id=302784&action=review</a>
<span class="quote">> LayoutTests/ChangeLog:10
> + differently but download success.</span >
success -> succeeds
<span class="quote">> Source/WebCore/ChangeLog:9
> + Use libsoup to get the suggested filename from the Content-Disposition header instead of buggy
> + filenameFromHTTPContentDisposition().</span >
What is buggy about it? Shouldn't we fix that bug, especially if it's affecting all ports? It sounds like it requires a adding FIXME at least?
I'd rather use libsoup to get the filename *inside* the implementation of filenameFromHTTPContentDisposition if need be. Avoiding use of filenameFromHTTPContentDisposition feels like a workaround.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>