<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Rename 'commit_parent' in 'commits' table to 'commit_previous_commit'."
href="https://bugs.webkit.org/show_bug.cgi?id=168816">bug 168816</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #302630 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Rename 'commit_parent' in 'commits' table to 'commit_previous_commit'."
href="https://bugs.webkit.org/show_bug.cgi?id=168816#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Rename 'commit_parent' in 'commits' table to 'commit_previous_commit'."
href="https://bugs.webkit.org/show_bug.cgi?id=168816">bug 168816</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=302630&action=diff" name="attach_302630" title="Patch">attachment 302630</a> <a href="attachment.cgi?id=302630&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302630&action=review">https://bugs.webkit.org/attachment.cgi?id=302630&action=review</a>
r=me with previous_commit > previousCommit in JSON API.
<span class="quote">> Websites/perf.webkit.org/public/include/commit-log-fetcher.php:124
> - 'parent' => $commit_row['commit_parent'],
> + 'previous_commit' => $commit_row['commit_previous_commit'],</span >
We should be using camelCase for JSON API.
<span class="quote">> Websites/perf.webkit.org/tools/sync-commits.py:234
> - 'parent': parent_hash,
> + 'previous_commit': previous_hash,</span >
This should also be previousCommit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>