<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Hangs when showing Google search results"
href="https://bugs.webkit.org/show_bug.cgi?id=168699#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Hangs when showing Google search results"
href="https://bugs.webkit.org/show_bug.cgi?id=168699">bug 168699</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=168699#c8">comment #8</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=302509&action=diff" name="attach_302509" title="Patch">attachment 302509</a> <a href="attachment.cgi?id=302509&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=302509&action=review">https://bugs.webkit.org/attachment.cgi?id=302509&action=review</a></span >
Thanks for the review Fuji!
<span class="quote">> > Source/WebKit2/ChangeLog:13
> > + socket monitor as readSocketMonitor and adds another one for polling output. When sendsmg fails with
>
> s/sendsmg/sendmsg/</span >
Oops
<span class="quote">> > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:365
> > +bool Connection::sendOutputMessage(UnixMessage& outputMessage)
>
> Mac port uses unique_ptr. You don't use unique_ptr<UnixMessage> for
> outputMessage for performance?</span >
Yes, the case of EWOULDBLOCK hardly ever happens, so only in that case I heap allocate the message to saved it.
<span class="quote">> > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:458
> > + sendOutputMessage(*message);
>
> You don't need to check the return value of sendOutputMessage?</span >
I'm assuming it won't fail because the poll said we can write without blocking. In any case, what we do is calling sendOutgoingMessages() that will return early if sendOutputMessage failed.
<span class="quote">> > Source/WebKit2/Platform/IPC/unix/UnixMessage.h:66
> > +class AttachmentInfo {
>
> You don't need to move AttachmentInfo, too.</span >
Right.
<span class="quote">> > Source/WebKit2/Platform/IPC/unix/UnixMessage.h:114
> > + memcpy(m_body, other.m_body, m_messageInfo.bodySize());
>
> You don't need to copy the body if m_messageInfo.isMessageBodyIsOutOfLine().</span >
Good point!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>