<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - AutoInstaller should not skip the install step if the package is downloaded but not installed"
href="https://bugs.webkit.org/show_bug.cgi?id=168737">168737</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>AutoInstaller should not skip the install step if the package is downloaded but not installed
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>clopez@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>lforschler@apple.com, youennf@gmail.com
</td>
</tr></table>
<p>
<div>
<pre>When installing a python library for the tests via AutoInstaller, there is an optional argument "should_refresh" that can be defined to instruct the installer to always re-download and re-install such package.
The issue is that "should_refresh" only checks if the source tarball is downloaded, but it ignores the fact that it can be already installed or not
This can happen if the user manually cleans the installation folder for the auto-installed python libraries or if the installation of the library failed previously for any reason.
So... what ends happening is that the module never gets installed.
This has bitten me, I was cleaning the automatically installed wpt-tools library at LayoutTests/imported/w3c/web-platform-tests/tools, but wiping the tools sub-directory never caused this library to be installed again.
The check to decide if the installation step should be skipped, it was only checking for the existence of the file defined at LayoutTests/imported/w3c/web-platform-tests/.tools.url rather than checking also for the target directory to exist.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>