<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Reduce platform ifdefs in WebKit2 custom protocols implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=165028">bug 165028</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>mcatanzaro@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Reduce platform ifdefs in WebKit2 custom protocols implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=165028#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Reduce platform ifdefs in WebKit2 custom protocols implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=165028">bug 165028</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=165028#c10">comment #10</a>)
<span class="quote">> > WebKit coding style says to use final, not override.
>
> Even for a class already marked as final?</span >
I strongly prefer override to final because it's much more descriptive and it doesn't seem particularly useful to prohibit overriding particular methods. But yes, we discussed it on webkit-dev a while back and IIRC agreed to use final in all cases except where the function needs to be overridden a second time, for better or for worse. We've been ignoring that in our GTK+ patches but should probably start using it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>