<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - JSC: missing implementations of MacroAssemblerMIPS::load8SignedExtendTo32()"
href="https://bugs.webkit.org/show_bug.cgi?id=168350">bug 168350</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #301574 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - JSC: missing implementations of MacroAssemblerMIPS::load8SignedExtendTo32()"
href="https://bugs.webkit.org/show_bug.cgi?id=168350#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - JSC: missing implementations of MacroAssemblerMIPS::load8SignedExtendTo32()"
href="https://bugs.webkit.org/show_bug.cgi?id=168350">bug 168350</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301574&action=diff" name="attach_301574" title="Patch">attachment 301574</a> <a href="attachment.cgi?id=301574&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301574&action=review">https://bugs.webkit.org/attachment.cgi?id=301574&action=review</a>
r=me with a fix.
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:764
> + }</span >
Looks good.
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:796
> + load8(address.m_ptr, dest);</span >
Why is it OK? I think we should use load8SignedExtendTo32 here (and delegate to `void load8SignedExtendTo32(const void* address, RegisterID dest)`), correct?
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:806
> + m_assembler.lb(dest, addrTempRegister, 0);</span >
OK. The difference from load8 is using lb instead of lbu.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>