<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add new WKWebKit Cocoa API for getContentsAsString"
href="https://bugs.webkit.org/show_bug.cgi?id=168147">bug 168147</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #301407 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add new WKWebKit Cocoa API for getContentsAsString"
href="https://bugs.webkit.org/show_bug.cgi?id=168147#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add new WKWebKit Cocoa API for getContentsAsString"
href="https://bugs.webkit.org/show_bug.cgi?id=168147">bug 168147</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301407&action=diff" name="attach_301407" title="Patch">attachment 301407</a> <a href="attachment.cgi?id=301407&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301407&action=review">https://bugs.webkit.org/attachment.cgi?id=301407&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3807
> + auto handler = adoptNS([completionHandler copy]);</span >
This should probably use BlockPtr these days.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3813
> + RetainPtr<NSError> error = adoptNS([[NSError alloc] init]);</span >
This actually logs an error, and the other uses (of [[NSError alloc] init]) are wrong. Should we fix it? Or just propagate the wrongness.
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm:42
> + NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
> + [webView loadRequest:request];
> + [webView _test_waitForDidFinishNavigation];</span >
If you want, if you use the TestWKWebView subclass instead of WKWebView directly, it has synchronouslyLoadTestPageNamed, which will replace all of these lines.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>