<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - EWS should run JavaScriptCore tests"
href="https://bugs.webkit.org/show_bug.cgi?id=162458#c46">Comment # 46</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - EWS should run JavaScriptCore tests"
href="https://bugs.webkit.org/show_bug.cgi?id=162458">bug 162458</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301437&action=diff" name="attach_301437" title="Patch">attachment 301437</a> <a href="attachment.cgi?id=301437&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301437&action=review">https://bugs.webkit.org/attachment.cgi?id=301437&action=review</a>
<span class="quote">> Tools/QueueStatusServer/model/queuestatus.py:46
> + return self.message.startswith(messages.skip_status)</span >
I just noticed that this disagrees with what I wrote in my second remark in <a href="show_bug.cgi?id=162458#c42">comment 42</a>, which implemented this function using a strict string comparision. Unless the EWS code does not emit skip_status (what does it emit when AbstractPatchQueue.did_fail() is invoked?) when skipping a patch by default, I do not feel there is value in having the EWS code (in webkitpy) emits a message of the form "Patch not applicable to %s."</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>