<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r212192): [GTK] Broke downloads API tests"
href="https://bugs.webkit.org/show_bug.cgi?id=168193">bug 168193</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>cgarcia@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r212192): [GTK] Broke downloads API tests"
href="https://bugs.webkit.org/show_bug.cgi?id=168193#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r212192): [GTK] Broke downloads API tests"
href="https://bugs.webkit.org/show_bug.cgi?id=168193">bug 168193</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=168193#c0">comment #0</a>)
<span class="quote">> Implementing MIMETypeRegistry::getPreferredExtensionForMIMEType in r212192
> broke our downloads API test:
>
> TEST:
> ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/
> TestDownloads... (pid=31826)
>
> /webkit2/Downloads/local-file: OK
>
> /webkit2/Downloads/overwrite-destination-allowed: OK
>
> /webkit2/Downloads/overwrite-destination-disallowed: OK
>
> /webkit2/Downloads/local-file-error: OK
>
> /webkit2/Downloads/remote-file: **
>
> ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:186:void
> DownloadTest::checkDestinationAndDeleteFile(WebKitDownload*, const char*):
> assertion failed (destBasename.get() == expectedName):
> ("webkit-downloaded-file.pdf" == "webkit-downloaded-file")
>
> FAIL
>
> I guess it's now expected that the .pdf file extension be added even though
> it's not included in the server suggested filename, so the change was
> correct and the test should be updated, right? It seems a bit odd that we
> would add the file extension on the client side, but I guess that's the
> expected behavior?</span >
Yes, it's a matter of checking the extension now too. I was going to do it yesterday but was tired, I'll fix this today. It's the suggested filename, it's perfectly ok to suggest a filename with a extension when we know the mime type.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>