<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Non-accelerated drawing is broken with HiDPI"
href="https://bugs.webkit.org/show_bug.cgi?id=168128#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Non-accelerated drawing is broken with HiDPI"
href="https://bugs.webkit.org/show_bug.cgi?id=168128">bug 168128</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=168128#c17">comment #17</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=168128#c15">comment #15</a>)
> > This has nothing to do with DRI3, the only problem is the device scale
> > factor.
>
> Right, I forgot to mention that my old laptop, apart from having DRI3
> disabled, does _not_ have a HiDPI screen.
>
> I built WebKitGTK+ locally with your patch applied, and I can confirm
> that MiniBrowser correctly paints websites now, both using 1x and 2x
> scale-factor. Tested with all the combinations of environment variables:
>
> % run-minibrowser --gtk --debug # No environment varible.
> % WEBKIT_DISABLE_COMPOSITING_MODE=1 run-minibrowser --gtk --debug
> % WEBKIT_FORCE_COMPOSITING_MODE=1 run-minibrowser --gtk --debug
>
> So informal r+ from me — now that I see what it does, it makes sense.
>
> - - - - -
>
> Side question: is there some way in which we could avoid this kind of
> regression in the future? It would be interesting to do some automated
> smoketesting, like building and loading a few selected websites with
> MiniBrowser under the control of a script, capturing the screen, and
> checking that there are non-blank pixels on a capture of the window, for
> different scale-factors and AC/non-AC modes.</span >
We should enable hidpi layout tests.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>