<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Handle caps lock indicator in event modifiers"
href="https://bugs.webkit.org/show_bug.cgi?id=168186#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Handle caps lock indicator in event modifiers"
href="https://bugs.webkit.org/show_bug.cgi?id=168186">bug 168186</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=168186#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=301299&action=diff" name="attach_301299" title="Patch">attachment 301299</a> <a href="attachment.cgi?id=301299&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=301299&action=review">https://bugs.webkit.org/attachment.cgi?id=301299&action=review</a>
>
> > LayoutTests/ChangeLog:9
> > + Add platform specific results for fast/events/special-key-events-in-input-text.html. This patch fixes the caps
> > + lock key case, but we still have different results in the PrintScreen case.
>
> What's different about the PrintScreen case? Do we not ever want to fix it?</span >
-INPUT - keydown - false,false,false,false,false - PrintScreen - KeyA - PrintScreen - 44 - 0. Value: "".
-INPUT - keyup - false,false,false,false,false - PrintScreen - KeyA - PrintScreen - 44 - 0. Value: "".
+INPUT - keydown - false,false,false,false,false - PrintScreen - PrintScreen - PrintScreen - 44 - 0. Value: "".
+INPUT - keyup - false,false,false,false,false - PrintScreen - PrintScreen - PrintScreen - 44 - 0. Value: "".
I don't think there's anything to fix there, KeyA doesn't look like the right key code for PrintScreen.
<span class="quote">> > Source/WebCore/platform/PlatformKeyboardEvent.h:169
> > + static bool modifiersContainCapsLock(unsigned);
>
> This header is already a mess, so I guess it's OK, but I dislike adding a
> special function here just for CapsLock. I'd prefer a generic function:
>
> static bool modifiersContainModifier(unsigned, PlatformEvent::Modifier)
>
> that you would pass PlatformEvent::Modifier::CapsLockKey to. Even if it's
> currently only used for CapsLock. But your choice.</span >
There are other similar static functions there and currentCapsLockState().
<span class="quote">> > Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:1325
> > + // In X11 GDK_LOCK_MASK could be CapsLock or ShiftLock. What GTK+ does in the X11 backend is checking if
>
> This code really confused me. I wrote a decent-length WTF comment to ask you
> to explain why it would ever be impossible for GTK+ to generate
> GDK_KEY_Caps_Lock. The key is to understand that it depends on the nutty
> modifier mapping of the X server. So I'd add that to your comment:
>
> "In X11 GDK_LOCK_MASK could be CapsLock or ShiftLock, depending on the
> modifier mapping of the X server."</span >
Ok.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>