<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Handle caps lock indicator in event modifiers"
href="https://bugs.webkit.org/show_bug.cgi?id=168186">bug 168186</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #301299 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Handle caps lock indicator in event modifiers"
href="https://bugs.webkit.org/show_bug.cgi?id=168186#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Handle caps lock indicator in event modifiers"
href="https://bugs.webkit.org/show_bug.cgi?id=168186">bug 168186</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301299&action=diff" name="attach_301299" title="Patch">attachment 301299</a> <a href="attachment.cgi?id=301299&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301299&action=review">https://bugs.webkit.org/attachment.cgi?id=301299&action=review</a>
<span class="quote">> LayoutTests/ChangeLog:9
> + Add platform specific results for fast/events/special-key-events-in-input-text.html. This patch fixes the caps
> + lock key case, but we still have different results in the PrintScreen case.</span >
What's different about the PrintScreen case? Do we not ever want to fix it?
<span class="quote">> Source/WebCore/platform/PlatformKeyboardEvent.h:169
> + static bool modifiersContainCapsLock(unsigned);</span >
This header is already a mess, so I guess it's OK, but I dislike adding a special function here just for CapsLock. I'd prefer a generic function:
static bool modifiersContainModifier(unsigned, PlatformEvent::Modifier)
that you would pass PlatformEvent::Modifier::CapsLockKey to. Even if it's currently only used for CapsLock. But your choice.
<span class="quote">> Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:1325
> + // In X11 GDK_LOCK_MASK could be CapsLock or ShiftLock. What GTK+ does in the X11 backend is checking if</span >
This code really confused me. I wrote a decent-length WTF comment to ask you to explain why it would ever be impossible for GTK+ to generate GDK_KEY_Caps_Lock. The key is to understand that it depends on the nutty modifier mapping of the X server. So I'd add that to your comment:
"In X11 GDK_LOCK_MASK could be CapsLock or ShiftLock, depending on the modifier mapping of the X server."</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>