<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - HTTPHeaderMap add methods are not consistent to each other"
href="https://bugs.webkit.org/show_bug.cgi?id=168115">bug 168115</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #301252 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - HTTPHeaderMap add methods are not consistent to each other"
href="https://bugs.webkit.org/show_bug.cgi?id=168115#c29">Comment # 29</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - HTTPHeaderMap add methods are not consistent to each other"
href="https://bugs.webkit.org/show_bug.cgi?id=168115">bug 168115</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301252&action=diff" name="attach_301252" title="Updated patch">attachment 301252</a> <a href="attachment.cgi?id=301252&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301252&action=review">https://bugs.webkit.org/attachment.cgi?id=301252&action=review</a>
Please fix the failing test on the Cocoa platforms before landing. I suspect that the comments about this code only affecting ports that don’t use CF was incorrect, given that a test result changed!
<span class="quote">> LayoutTests/imported/w3c/ChangeLog:3
> + HTTPHeaderMap add methods are not consistent to each other</span >
Either "are not consistent" or "are not consistent with each other" would be OK. But "are not consistent to each other" is not correct English grammar.
This is C++, so these are "functions", not "methods".
But, also, why be so vague about what the inconsistency is? The comment should mention the space after the comma instead of leaving a mystery about what the difference is. I would use this title:
REGRESSION (r206014): HTTPHeaderMap does not consistently use comma without space to separate values of header fields
<span class="quote">> Source/WebCore/ChangeLog:14
> + When the header already exists the values is appended after a ',' in both cases, but for common headers ", " is
> + used while for uncommon headers ',' is used. This makes test
> + imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive.htm to fail because of the
> + space difference. This doesn't affect ports using CF, because CF already joins the headers, so they don't use
> + HTTPHeaderMap::add(), but HTTPHeaderMap::set(). According to the HTTP spec, the space is optional, but fetch
> + spec says it shouldn't be any trailing/leading whitespace in values. So let's use ',' everywhere and update the
> + tests results to expect that.</span >
If you do a bit more research on the history of this function, you will see that this inconsistency was introduced by <<a href="https://trac.webkit.org/changeset/206014">https://trac.webkit.org/changeset/206014</a>>, a change that removed the space to match the Fetch specification. So I think the explanation is simpler than what you write here: We simply need to finish the job that was only partly done in that change.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>