<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - HTTPHeaderMap add methods are not consistent to each other"
href="https://bugs.webkit.org/show_bug.cgi?id=168115#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - HTTPHeaderMap add methods are not consistent to each other"
href="https://bugs.webkit.org/show_bug.cgi?id=168115">bug 168115</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Ok, looking at the tests in detail now I understand better what is going on
http/tests/xmlhttprequest/check-combining-headers.html
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm
These have FAIL lines in the expectations, like:
FAIL XMLHttpRequest: setRequestHeader() - combining headers (Authorization) assert_equals: Combined header value should be t1,t2 expected "t1,t2" but got "t1, t2"
Whatever patch we write for this bug should make those pass.
The other ones failing expect ',' not ", ".
And finally the one I was trying to fix expects ", " but it should really expect ','. According to the HTTP spec, the space is optional, but fetch spec says it shouldn't be any trailing/leaving whitespace in values, see <a href="https://fetch.spec.whatwg.org/#concept-header-list-combine">https://fetch.spec.whatwg.org/#concept-header-list-combine</a>. That's why it was changed in w3c web platform tests, but I think they forgot about imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive.htm. I guess it's not a good idea to change imported tests, so we can simply add a failure expectation for this test.
So, let's be consistent and use ',' everywhere. I'll submit a new patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>