<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][MSE] Some GStreamer log messages are generated with the 'default' category"
href="https://bugs.webkit.org/show_bug.cgi?id=168015">bug 168015</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #301178 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][MSE] Some GStreamer log messages are generated with the 'default' category"
href="https://bugs.webkit.org/show_bug.cgi?id=168015#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][MSE] Some GStreamer log messages are generated with the 'default' category"
href="https://bugs.webkit.org/show_bug.cgi?id=168015">bug 168015</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301178&action=diff" name="attach_301178" title="Patch">attachment 301178</a> <a href="attachment.cgi?id=301178&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301178&action=review">https://bugs.webkit.org/attachment.cgi?id=301178&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:27
> +#include <gst/gst.h></span >
This include does not seem to be needed, please confirm it and remove it.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:59
> +#define WEBKIT_MEDIA_SRC_CATEGORY_INIT GST_DEBUG_CATEGORY_INIT(webkit_media_src_debug, "webkitmediasrc", 0, "websrc element");</span >
Taking advantage of having to remove the include above and having to upload the patch again, let's change:
"websrc element" -> "web media source element"</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>