<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
href="https://bugs.webkit.org/show_bug.cgi?id=163208#c36">Comment # 36</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
href="https://bugs.webkit.org/show_bug.cgi?id=163208">bug 163208</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301063&action=diff" name="attach_301063" title="Patch">attachment 301063</a> <a href="attachment.cgi?id=301063&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301063&action=review">https://bugs.webkit.org/attachment.cgi?id=301063&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:833
> + if (JSScope* scope = jsDynamicCast<JSScope*>(exec->vm(), object)) {</span >
You already have a VM available here, no need to exec->vm().
<span class="quote">> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:837
> + result = ((JSCell*)object)->isObject();</span >
This should always be true.
<span class="quote">> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:839
> + result = ((JSCell*)object)->isObject();</span >
This should always be true. If it resolved to a with scope, with scopes can only be over objects, I think. It's worth verifying I'm correct. I suspect `with(foo) { ... }` will always toObject the `foo`.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>