<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Notifications API does not respect or expose the "icon" attribute"
href="https://bugs.webkit.org/show_bug.cgi?id=164986#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Notifications API does not respect or expose the "icon" attribute"
href="https://bugs.webkit.org/show_bug.cgi?id=164986">bug 164986</a>
from <span class="vcard"><a class="email" href="mailto:aperez@igalia.com" title="Adrian Perez <aperez@igalia.com>"> <span class="fn">Adrian Perez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164986#c2">comment #2</a>)
<span class="quote">> Let's start for now with just exposing the property, so it will at least be
> *possible* for apps to show web notifications with icons, even if
> WebKit-created notifications don't have icons yet.</span >
This seems reasonable, because anyway it would be unclear which icon
WebKitGTK+ would use when one is not explicitly defined. I would rather
not have a default fallback icon that trying to guess “too much” and end
up with heuristics. An application which wants to add their own icon may
be better off by connecting to the “WebKitWebView::show-notification”
signal, using a GNotification instead to add the icon (and probably more),
and finally preventing the WebKitGTK+ generic notification. The following
example shows that this is really easy to do:
<a href="https://github.com/aperezdc/revolt/blob/master/revolt/window.py#L142-L158">https://github.com/aperezdc/revolt/blob/master/revolt/window.py#L142-L158</a>
(Which makes me think: maybe we want to do something like that in Epiphany!)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>