<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r202615?): [GStreamer] ASSERTION FAILED: isMainThread() in WebCore::BuiltinResourceHandleConstructorMap& WebCore::builtinResourceHandleConstructorMap()"
href="https://bugs.webkit.org/show_bug.cgi?id=167003">bug 167003</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>cgarcia@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r202615?): [GStreamer] ASSERTION FAILED: isMainThread() in WebCore::BuiltinResourceHandleConstructorMap& WebCore::builtinResourceHandleConstructorMap()"
href="https://bugs.webkit.org/show_bug.cgi?id=167003#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r202615?): [GStreamer] ASSERTION FAILED: isMainThread() in WebCore::BuiltinResourceHandleConstructorMap& WebCore::builtinResourceHandleConstructorMap()"
href="https://bugs.webkit.org/show_bug.cgi?id=167003">bug 167003</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=167003#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=300089&action=diff" name="attach_300089" title="Patch">attachment 300089</a> <a href="attachment.cgi?id=300089&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=300089&action=review">https://bugs.webkit.org/attachment.cgi?id=300089&action=review</a>
>
> > Source/WebCore/ChangeLog:13
> > + (ResourceHandleStreamingClient::ResourceHandleStreamingClient): Create a SoupNetworkSession and apss it to ResourceHandle::create().
>
> apss -> pass
>
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1086
> > +#else
> > m_resource = ResourceHandle::create(nullptr /*context*/, request, this, true, false);
> > +#endif
>
> But this is always going to crash in the non-soup case.</span >
Yes, downstreams will have to do their own thing I guess. I can't do more in upstream.
<span class="quote">> Since there are zero non-soup ports using GStreamer (even Sony wants to
> avoid GStreamer), you should make it mandatory instead of leaving this
> broken code here for new ports to stumble upon. If you don't want to do
> that, then at the very least use RELEASE_ASSERT_NOT_REACHED() and add a
> FIXME.</span >
I'll add an ASSERT, I don't see why crashing a release build because of that, it has always worked in release, I don't think this is fatal at all.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>