<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: WKContentView needs to implement UITextInput methods to make speak selection highlighting work"
href="https://bugs.webkit.org/show_bug.cgi?id=166955#c27">Comment # 27</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: WKContentView needs to implement UITextInput methods to make speak selection highlighting work"
href="https://bugs.webkit.org/show_bug.cgi?id=166955">bug 166955</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=300061&action=diff" name="attach_300061" title="patch">attachment 300061</a> <a href="attachment.cgi?id=300061&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=300061&action=review">https://bugs.webkit.org/attachment.cgi?id=300061&action=review</a>
<span class="quote">> Source/WebCore/dom/Range.h:128
> + WEBCORE_EXPORT int collectSelectionRectsWithoutUnionInteriorLines(Vector<SelectionRect>&);</span >
Seems like line number should be unsigned rather than int.
<span class="quote">> Source/WebCore/editing/TextIterator.cpp:2681
> +static Ref<Range> findPlainTextMatchesInRange(const Range& range, const String& target, FindOptions options, size_t& matchStart, size_t& matchLength, const std::function<bool(size_t, size_t)>& matches)</span >
I find the design of this function quite peculiar and not straightforward as it should be. The idea that the function’s job is to fill in the two values, matchStart and matchLength, as a side effect, is super-strange. Can we find a more straightforward design pattern?
<span class="quote">> Source/WebCore/editing/TextIterator.cpp:2704
> + auto result = std::pair<size_t, size_t> { matchStart, matchLength };</span >
What’s the point of putting this into a pair, since we just break the pair apart below?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>