<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for Trac instances that host multiple projects."
href="https://bugs.webkit.org/show_bug.cgi?id=167524">bug 167524</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #299953 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for Trac instances that host multiple projects."
href="https://bugs.webkit.org/show_bug.cgi?id=167524#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for Trac instances that host multiple projects."
href="https://bugs.webkit.org/show_bug.cgi?id=167524">bug 167524</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299953&action=diff" name="attach_299953" title="Patch">attachment 299953</a> <a href="attachment.cgi?id=299953&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299953&action=review">https://bugs.webkit.org/attachment.cgi?id=299953&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:120
> - console.assert(fromDate <= toDate);
> + if (fromDate > toDate)
> + throw RangeError("Parameter fromDate should be before or on toDate.");</span >
Why this change? This is logically an assertion, so it's cleaner to express it as such.
Just like in C/C++, adding a unit test that violates an assertion is not worth it.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:131
> + "&from=" + encodeURIComponent(toDay.toISOString().slice(0, 10)) +
> + "&daysback=" + encodeURIComponent((toDay - fromDay) / 1000 / 60 / 60 / 24);</span >
Why add encodeURIComponent here if it's not needed?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>