<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
href="https://bugs.webkit.org/show_bug.cgi?id=163208">bug 163208</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #299744 is obsolete</td>
<td>1
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
href="https://bugs.webkit.org/show_bug.cgi?id=163208#c30">Comment # 30</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
href="https://bugs.webkit.org/show_bug.cgi?id=163208">bug 163208</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299744&action=diff" name="attach_299744" title="Patch">attachment 299744</a> <a href="attachment.cgi?id=299744&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299744&action=review">https://bugs.webkit.org/attachment.cgi?id=299744&action=review</a>
Thanks for review!!!
<span class="quote">>> Source/JavaScriptCore/ChangeLog:19
>> + op_is_scope_var_type - check if scope with variable is function scope
>
> Let's call this op_is_var_scope.
>
> I don't understand your explanation "check if scope with variable is function scope", but since op_resolve_closest_or_var_scope names something a "var scope", I'm inferring that this check applies to the same thing.</span >
I've tried to make it more clear in new patch
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:697
>> + RegisterID* emitResolveOuterVarScope(RegisterID* dst, const Identifier&);
>
> It is bad that this function name does not match the name of the bytecode it emits.</span >
Fixed
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:698
>> + RegisterID* emitCheckIfScopeIsVarType(RegisterID* dst, RegisterID* scope);
>
> Same comment here.</span >
Fixed
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:699
>> + RegisterID* emitPutToOuterScope(RegisterID* scope, const Identifier&, RegisterID* value, ResolveMode, InitializationMode);
>
> How is emitPutToOuterScope different from emitPutToScope?</span >
Yeah, now it is the same. Removed
<span class="quote">>> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:814
>> +SLOW_PATH_DECL(slow_path_resolve_closest_var_scope)
>
> You forgot the word "or" in this name, which changes its meaning significantly.</span >
Fixed
<span class="quote">>> Source/JavaScriptCore/runtime/JSScope.cpp:220
>> +ALWAYS_INLINE JSObject* JSScope::baseResolve(ExecState* exec, JSScope* scope, const Identifier& ident, FinishResolveEarlierFunctor finishResolveEarlier)
>
> There's no need to use a different function name here. You can call this resolve.</span >
Fixed
<span class="quote">>> Source/JavaScriptCore/runtime/JSScope.cpp:256
>> + if (finishResolveEarlier(scope))
>
> I would call this 'accept' or 'predicate'.</span >
Renamed</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>