<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
   href="https://bugs.webkit.org/show_bug.cgi?id=163208#c28">Comment # 28</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
   href="https://bugs.webkit.org/show_bug.cgi?id=163208">bug 163208</a>
              from <span class="vcard"><a class="email" href="mailto:ggaren&#64;apple.com" title="Geoffrey Garen &lt;ggaren&#64;apple.com&gt;"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=299744&amp;action=diff" name="attach_299744" title="Patch">attachment 299744</a> <a href="attachment.cgi?id=299744&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299744&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=299744&amp;action=review</a>

<span class="quote">&gt; Source/JavaScriptCore/ChangeLog:19
&gt; +        op_is_scope_var_type - check if scope with variable is function scope           </span >

Let's call this op_is_var_scope. 

I don't understand your explanation &quot;check if scope with variable is function scope&quot;, but since op_resolve_closest_or_var_scope names something a &quot;var scope&quot;, I'm inferring that this check applies to the same thing.

<span class="quote">&gt; Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:697
&gt; +        RegisterID* emitResolveOuterVarScope(RegisterID* dst, const Identifier&amp;);</span >

It is bad that this function name does not match the name of the bytecode it emits.

<span class="quote">&gt; Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:698
&gt; +        RegisterID* emitCheckIfScopeIsVarType(RegisterID* dst, RegisterID* scope);</span >

Same comment here.

<span class="quote">&gt; Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:699
&gt; +        RegisterID* emitPutToOuterScope(RegisterID* scope, const Identifier&amp;, RegisterID* value, ResolveMode, InitializationMode);</span >

How is emitPutToOuterScope different from emitPutToScope?

<span class="quote">&gt; Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:814
&gt; +SLOW_PATH_DECL(slow_path_resolve_closest_var_scope)</span >

You forgot the word &quot;or&quot; in this name, which changes its meaning significantly.

<span class="quote">&gt; Source/JavaScriptCore/runtime/JSScope.cpp:220
&gt; +ALWAYS_INLINE JSObject* JSScope::baseResolve(ExecState* exec, JSScope* scope, const Identifier&amp; ident, FinishResolveEarlierFunctor finishResolveEarlier)</span >

There's no need to use a different function name here. You can call this resolve.

<span class="quote">&gt; Source/JavaScriptCore/runtime/JSScope.cpp:256
&gt; +        if (finishResolveEarlier(scope))</span >

I would call this 'accept' or 'predicate'.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>