<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:agouaillard@gmail.com" title="Alex. Gouaillard <agouaillard@gmail.com>"> <span class="fn">Alex. Gouaillard</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - This bug is here just to trace the extra changes for information and discussion on the webkit side."
href="https://bugs.webkit.org/show_bug.cgi?id=167450">bug 167450</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>agouaillard@gmail.com
</td>
</tr>
<tr>
<td style="text-align:right;">Priority</td>
<td>P2
</td>
<td>P3
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - This bug is here just to trace the extra changes for information and discussion on the webkit side."
href="https://bugs.webkit.org/show_bug.cgi?id=167450#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - This bug is here just to trace the extra changes for information and discussion on the webkit side."
href="https://bugs.webkit.org/show_bug.cgi?id=167450">bug 167450</a>
from <span class="vcard"><a class="email" href="mailto:agouaillard@gmail.com" title="Alex. Gouaillard <agouaillard@gmail.com>"> <span class="fn">Alex. Gouaillard</span></a>
</span></b>
<pre>The default libwebrtc compiles with VP* always ON.
While this patch uses the same implementation that was used for VP9 upstream, it does not modify the build files accordingly.
The proposed solution is to add a GN configuration to reflect that this is a build in webkit, just like the two existing flags that differentiates the standalone build (default), chromium build (build_with_chromium), and the firefox build (build_with firefox). It's more consistent, and it also allows for less post processing of GN Generated files in webkit. Just like firefox flag, it is more prone to breakage, and would be more or less th responsibility of the webkit maintainers to make sure it is kept updated.
changes:
in /webrtc/webrtc.gni:
rtc_libvpx_build_vp8 = true
if (build_with_webkit) {
etc_libvpx_build_vp8 = false
}
in /webrtc/BUILD.gn:
if (!rtc_libvpx_build_vp8) {
defines += [ "RTC_DISABLE_VP8" ]
}
if (build_with_webkit) {
defines += [ "WEBRTC_WEBKIT_BUILD" ]
}
in /webrtc/modules/video_coding/BUILD.gn:
rtc_static_library("webrtc_vp8") {
if (rtc_libvpx_build_vp8) {
sources = [
"codecs/vp8/include/vp8.h",
"codecs/vp8/vp8_impl.cc",
"codecs/vp8/vp8_impl.h",
]
} else {
sources = [
"codecs/vp8/vp8_noop.cc",
]
}</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>