<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Speak Selection does not work in an iframe"
href="https://bugs.webkit.org/show_bug.cgi?id=166794#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Speak Selection does not work in an iframe"
href="https://bugs.webkit.org/show_bug.cgi?id=166794">bug 166794</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299368&action=diff" name="attach_299368" title="patch with test">attachment 299368</a> <a href="attachment.cgi?id=299368&action=edit" title="patch with test">[details]</a></span>
patch with test
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299368&action=review">https://bugs.webkit.org/attachment.cgi?id=299368&action=review</a>
<span class="quote">>> Source/WebKit2/ChangeLog:8
>> +
>
> will this also handle the case of just text nodes highlighted (I ask because I don't know if focus moves to a frame if you just highlight text in that frame)</span >
That's how getSelectionContext() works. So I would say yes.
<span class="quote">>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2333
>> +{
>
> can you put a comment here about who uses this</span >
Ok, but currently only the test uses it.
<span class="quote">>> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:116
>> + [webView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:^(void) {
>
> (void) probably not necessary to include
>
> ^{ probably will work</span >
ok
<span class="quote">>> LayoutTests/accessibility/ios-simulator/speak-selection-content.html:17
>> +<input type="text" id="myText" value="Text outside iframe">
>
> let's also test selecting text that's not inside a input type</span >
Ok.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>