<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Pass down website autoplay policies to media elements"
   href="https://bugs.webkit.org/show_bug.cgi?id=167132#c9">Comment # 9</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Pass down website autoplay policies to media elements"
   href="https://bugs.webkit.org/show_bug.cgi?id=167132">bug 167132</a>
              from <span class="vcard"><a class="email" href="mailto:achristensen&#64;apple.com" title="Alex Christensen &lt;achristensen&#64;apple.com&gt;"> <span class="fn">Alex Christensen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=299073&amp;action=diff" name="attach_299073" title="Patch">attachment 299073</a> <a href="attachment.cgi?id=299073&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299073&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=299073&amp;action=review</a>

<span class="quote">&gt; Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:821
&gt; +    if (coreFrame &amp;&amp; !websitePolicies.autoplayEnabled) {</span >

I don't think we need to check coreFrame.  It was dereferenced on line 804, so if it were null we would have already crashed.

<span class="quote">&gt; Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:824
&gt; +        settings.setVideoPlaybackRequiresUserGesture(true);
&gt; +        settings.setAudioPlaybackRequiresUserGesture(true);</span >

Are these values set back to their default value for the next navigation?  Add a test that sets autoplayEnabled back to true and does another navigation to make sure that it behaves as expected.

<span class="quote">&gt; Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html:12
&gt; +                }, 100)</span >

Is 100ms enough time for the video to have always started playing when it is allowed to?</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>