<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:commit-queue@webkit.org" title="WebKit Commit Bot <commit-queue@webkit.org>"> <span class="fn">WebKit Commit Bot</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WebInspector: refactor RemoteInspector to move cocoa specific code to their own files"
href="https://bugs.webkit.org/show_bug.cgi?id=166681">bug 166681</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>commit-queue@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebInspector: refactor RemoteInspector to move cocoa specific code to their own files"
href="https://bugs.webkit.org/show_bug.cgi?id=166681#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebInspector: refactor RemoteInspector to move cocoa specific code to their own files"
href="https://bugs.webkit.org/show_bug.cgi?id=166681">bug 166681</a>
from <span class="vcard"><a class="email" href="mailto:commit-queue@webkit.org" title="WebKit Commit Bot <commit-queue@webkit.org>"> <span class="fn">WebKit Commit Bot</span></a>
</span></b>
<pre><span class=""><a href="attachment.cgi?id=298462&action=diff" name="attach_298462" title="WIP: trying xcode changes">Attachment 298462</a> <a href="attachment.cgi?id=298462&action=edit" title="WIP: trying xcode changes">[details]</a></span> did not pass style-queue:
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:111: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:153: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:82: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:163: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:164: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:164: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:198: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:199: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:199: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:216: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:217: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:217: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:50: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:69: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:71: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:147: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:209: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:452: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:562: No space between ^ and block definition. [whitespace/brackets] [4]
ERROR: Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:588: No space between ^ and block definition. [whitespace/brackets] [4]
Total errors found: 20 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>