<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=166886">bug 166886</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #298454 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=166886#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=166886">bug 166886</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=298454&action=diff" name="attach_298454" title="Patch">attachment 298454</a> <a href="attachment.cgi?id=298454&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=298454&action=review">https://bugs.webkit.org/attachment.cgi?id=298454&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:9
> + smart pointers, uses WTF::Vactor instead of GSList and simplifies the code to map/unmap GstBuffers.</span >
WTF:Vector
<span class="quote">> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:353
> + auto& buffer = channelBufferList[i];</span >
Specify the type, please
<span class="quote">> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:362
> + auto& appsrc = priv->sources[i];</span >
Specify the type, please
<span class="quote">> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:403
> + src->priv->pool = adoptGRef(gst_buffer_pool_new());</span >
gst_buffer_pool_new returns a floating reference. According to the defined adoptGRef for this time, this should trigger the ASSERT.
Not adopting is ok here.
Actually in line 221 a similar thing is done correctly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>