<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Move cache coders to WTF"
   href="https://bugs.webkit.org/show_bug.cgi?id=166825#c9">Comment # 9</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Move cache coders to WTF"
   href="https://bugs.webkit.org/show_bug.cgi?id=166825">bug 166825</a>
              from <span class="vcard"><a class="email" href="mailto:mcatanzaro&#64;igalia.com" title="Michael Catanzaro &lt;mcatanzaro&#64;igalia.com&gt;"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
        <pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=298319&amp;action=diff" name="attach_298319" title="patch">attachment 298319</a> <a href="attachment.cgi?id=298319&amp;action=edit" title="patch">[details]</a></span>
patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=298319&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=298319&amp;action=review</a>

<span class="quote">&gt; Source/WTF/wtf/persistence/Coders.cpp:35
&gt; +#include &quot;NetworkCacheCoders.h&quot;
&gt; +
&gt; +#if ENABLE(NETWORK_CACHE)
&gt; +
&gt; +#include &lt;wtf/text/CString.h&gt;
&gt; +#include &lt;wtf/text/WTFString.h&gt;
&gt; +
&gt; +namespace WebKit {
&gt; +namespace NetworkCache {</span >

Are you planning to get rid of the ENABLE(NETWORK_CACHE) and namespace NetworkCache?

<span class="quote">&gt; Source/WTF/wtf/persistence/Coders.cpp:160
&gt; +// Store common HTTP headers as strings instead of using their value in the HTTPHeaderName enumeration
&gt; +// so that the headers stored in the cache stays valid even after HTTPHeaderName.in gets updated.
&gt; +void Coder&lt;WebCore::HTTPHeaderMap&gt;::encode(Encoder&amp; encoder, const WebCore::HTTPHeaderMap&amp; headers)</span >

Er, surely WTF cannot depend on WebCore.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>