<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESNext] Async iteration - Implement Async Generator"
href="https://bugs.webkit.org/show_bug.cgi?id=166695#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESNext] Async iteration - Implement Async Generator"
href="https://bugs.webkit.org/show_bug.cgi?id=166695">bug 166695</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=298373&action=diff" name="attach_298373" title="Patch">attachment 298373</a> <a href="attachment.cgi?id=298373&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=298373&action=review">https://bugs.webkit.org/attachment.cgi?id=298373&action=review</a>
quick review. I'll review it in detail later.
<span class="quote">> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1179
> + dataLogF("Creating async function!\n");</span >
Nit: `async generator function`.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:2740
> + bool isAsyncGeneratorMethod = false;</span >
Instead of adding more flags, cleaning up these flags is better.
You can combine `isGenerator`, `isAsync`, `isAsyncGenerator`, `isAsyncMethod`, `isAsyncGeneratorMethod` etc. carefully to one enum, right?
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:3808
> + bool isAsyncGenerator = false;
> + bool isAsyncGeneratorMethod = false;</span >
Ditto
<span class="quote">> Source/JavaScriptCore/runtime/AsyncGeneratorFunctionConstructor.h:36
> + typedef InternalFunction Base;</span >
For the newer code, let's use `using Base = JSFunction;`.
<span class="quote">> Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototype.h:33
> + typedef JSNonFinalObject Base;</span >
For the newer code, let's use `using Base = JSFunction;`.
<span class="quote">> Source/JavaScriptCore/runtime/AsyncGeneratorPrototype.h:36
> + typedef JSNonFinalObject Base;</span >
For the newer code, let's use `using Base = JSFunction;`.
<span class="quote">> Source/JavaScriptCore/runtime/AsyncIteratorPrototype.h:34
> + typedef JSNonFinalObject Base;</span >
For the newer code, let's use `using Base = JSFunction;`.
<span class="quote">> Source/JavaScriptCore/runtime/JSAsyncGeneratorFunction.h:36
> + typedef JSFunction Base;</span >
For the newer code, let's use `using Base = JSFunction;`.
<span class="quote">> Source/JavaScriptCore/runtime/JSFunction.cpp:356
> + // prototype = constructEmptyObject(exec, thisObject->globalObject(vm)->asyncGeneratorPrototype());</span >
This line is not necessary.
<span class="quote">> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:1223
> + visitor.append(thisObject->m_asyncGeneratorPrototype);</span >
m_asyncIteratorPrototype and m_asyncGeneratorFunctionPrototype need to be visited.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>