<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Since the memory pressure relief has been activated, my disk has a high usage and the desktop stalls"
href="https://bugs.webkit.org/show_bug.cgi?id=164052">bug 164052</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #294370 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Since the memory pressure relief has been activated, my disk has a high usage and the desktop stalls"
href="https://bugs.webkit.org/show_bug.cgi?id=164052#c26">Comment # 26</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Since the memory pressure relief has been activated, my disk has a high usage and the desktop stalls"
href="https://bugs.webkit.org/show_bug.cgi?id=164052">bug 164052</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294370&action=diff" name="attach_294370" title="Patch">attachment 294370</a> <a href="attachment.cgi?id=294370&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294370&action=review">https://bugs.webkit.org/attachment.cgi?id=294370&action=review</a>
<span class="quote">> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:291
> + size_t processMemory = processMemoryUsage();</span >
That reminds me that this function ought to return a pair of values now, see <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Memory warning logging appears to capture resident footprint, missing compress/swap."
href="show_bug.cgi?id=165533">bug #165533</a>. But that's a separate issue that doesn't have to be fixed here.
<span class="quote">> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:293
> + int64_t bytesFreed = processMemory - processMemoryUsage();</span >
Careful, you have integer underflow here, you have to cast either processMemory or processMemoryUsage to int64_t on the right hand side of the assignment as the result of the subtraction is a size_t. i.e. the value has already underflowed before it gets assigned to the int64_t. It might work properly on x86_64, but with a 32-bit size_t I think you'd wind up with a huge positive number for bytesFreed when it should be negative.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>