<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
href="https://bugs.webkit.org/show_bug.cgi?id=163208#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6]. Implement Annex B.3.3 function hoisting rules for eval"
href="https://bugs.webkit.org/show_bug.cgi?id=163208">bug 163208</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=296084&action=diff" name="attach_296084" title="Patch">attachment 296084</a> <a href="attachment.cgi?id=296084&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=296084&action=review">https://bugs.webkit.org/attachment.cgi?id=296084&action=review</a>
<span class="quote">>> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2876
>> + // Fixme: we do not have llint optimization for those op_codes
>
> Please file a bug for this if you think we should do it. That said, this is way more than a LLInt optimization, knowing which scope you'll resolve to helps in all tiers.</span >
Done
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:769
>> + }
>
> Do you mind elaborating on your previous example for why you said this is needed, I don't quite get it.</span >
I've removed this change. It seems that not ready yet.
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2193
>> + // resolve_scope dst, id, ResolveType, skipLocalScope
>
> This comment is wrong. It has the wrong bytecode name.</span >
Removed
<span class="quote">>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2208
>> + // resolve_scope dst, scope id
>
> Ditto.</span >
Removed
<span class="quote">>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1109
>> + break;
>
> This feels wrong, AI should be able to handle a constant you don't expect. That said, I think this only allows for scope arguments, however, I think this would break if a `with` scope or some other scope was the argument to this. It seems totally possible that other scopes can be your constant argument here.</span >
Yeah. I've just removed this part. I did not managed to find case when child.value().isObject() is valid. So Only forNode(node).setType(m_graph, SpecBoolean) is left.
<span class="quote">>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2848
>> + case ResolveClosestVarScope:
>
> You also need a rule for IsVarScopeType here.
> Did this not cause any issues for you? If seems like it should lead to a crash, so please add a test that stresses this.</span >
Done
<span class="quote">>> Source/JavaScriptCore/dfg/DFGNode.h:994
>> + }
>
> should be uint32_t</span >
Removed
<span class="quote">>> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:2118
>> + loadisFromInstruction(4, t0)
>
> I don't think this is needed.</span >
Removed
<span class="quote">>> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:2124
>> + loadisFromInstruction(4, t0)
>
> Ditto</span >
Removed
<span class="quote">>> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:2069
>> + loadisFromInstruction(4, t0)
>
> ditto</span >
Removed
<span class="quote">>> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:2075
>> + loadisFromInstruction(4, t0)
>
> ditto</span >
Removed</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>