<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash on drag above web view of nautilus' tab"
href="https://bugs.webkit.org/show_bug.cgi?id=166059#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash on drag above web view of nautilus' tab"
href="https://bugs.webkit.org/show_bug.cgi?id=166059">bug 166059</a>
from <span class="vcard"><a class="email" href="mailto:mcrha@redhat.com" title="Milan Crha <mcrha@redhat.com>"> <span class="fn">Milan Crha</span></a>
</span></b>
<pre>Yes, I wouldn't suggest to check for `this != NULL`, illegal or not, it looks and feels awkward and like a very bad hack. What I've on my mind is to change the asserts into a real runtime check, instead of "check only in debug build, or whatever". That will make the code more robust. And if you feel that it'll hide some issues, then keep there both the assert and the runtime check, and eventually print a runtime warning if the runtime check fails, if you think that the DragAndDropHandler cannot be NULL in all cases.
In other words, the change should come, from my point of view, into webkitWebViewBaseDragDrop() and the related drag & drop functions, instead of into the DragAndDropHandler class.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>