<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Macro expansion producing 'defined' has undefined behavior"
href="https://bugs.webkit.org/show_bug.cgi?id=166047#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Macro expansion producing 'defined' has undefined behavior"
href="https://bugs.webkit.org/show_bug.cgi?id=166047">bug 166047</a>
from <span class="vcard"><a class="email" href="mailto:ttsugrii@fb.com" title="Taras Tsugrii <ttsugrii@fb.com>"> <span class="fn">Taras Tsugrii</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=297554&action=diff" name="attach_297554" title="Patch">attachment 297554</a> <a href="attachment.cgi?id=297554&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=297554&action=review">https://bugs.webkit.org/attachment.cgi?id=297554&action=review</a>
<span class="quote">>> Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:34
>> +#define WK_API_ENABLED 1
>
> This seems a bit inelegant. I would write:
>
> #if TARGET_OS_IPHONE || (defined(__clang__) && defined(__APPLE__) && !defined(__i386__))
> <...>
> #endif
>
> Rather than #if #else #if #else.</span >
doh, I was so laser focused on not breaking anything that I totally missed the external context. Thanks for the suggestion, Darin!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>