<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Macro expansion producing 'defined' has undefined behavior"
href="https://bugs.webkit.org/show_bug.cgi?id=166047">bug 166047</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #297554 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Macro expansion producing 'defined' has undefined behavior"
href="https://bugs.webkit.org/show_bug.cgi?id=166047#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Macro expansion producing 'defined' has undefined behavior"
href="https://bugs.webkit.org/show_bug.cgi?id=166047">bug 166047</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=297554&action=diff" name="attach_297554" title="Patch">attachment 297554</a> <a href="attachment.cgi?id=297554&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=297554&action=review">https://bugs.webkit.org/attachment.cgi?id=297554&action=review</a>
Looks good to me.
<span class="quote">> Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:34
> #if TARGET_OS_IPHONE
> #define WK_API_ENABLED 1
> #else
> -#define WK_API_ENABLED (defined(__clang__) && defined(__APPLE__) && !defined(__i386__))
> +#if (defined(__clang__) && defined(__APPLE__) && !defined(__i386__))
> +#define WK_API_ENABLED 1</span >
This seems a bit inelegant. I would write:
#if TARGET_OS_IPHONE || (defined(__clang__) && defined(__APPLE__) && !defined(__i386__))
<...>
#endif
Rather than #if #else #if #else.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>