<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] use FastMalloc-based GstAllocator"
href="https://bugs.webkit.org/show_bug.cgi?id=165793#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] use FastMalloc-based GstAllocator"
href="https://bugs.webkit.org/show_bug.cgi?id=165793">bug 165793</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=296994&action=diff" name="attach_296994" title="WIP">attachment 296994</a> <a href="attachment.cgi?id=296994&action=edit" title="WIP">[details]</a></span>
WIP
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=296994&action=review">https://bugs.webkit.org/attachment.cgi?id=296994&action=review</a>
<span class="quote">>> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:161
>> + fprintf(stderr, "initializeGStreamer(): using FastMalloc allocator %p\n", allocator);
>
> I would GST_INFO this, though it would require to add a debug category for this.</span >
It's a debugging leftover, can be removed.
<span class="quote">>> Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp:36
>> + auto* mem = reinterpret_cast<GstMemoryFastMalloc*>(fastAlignedMalloc(alignment + 1, headerSize + allocationSize));
>
> I prefer typed things when they are non-trivial, which IMHO is the case.</span >
This is typed like anything else, but it removes the duplicated information.
Also, static_cast<> can be used.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>